Feat/385 #391
Open
Feat/385 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
단일 객체에 하나의 프로퍼티만 가지므로 api 응답을 받아오는 과정에서 number 타입으로 가공해줌
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
uraflower
approved these changes
Jul 9, 2024
Comment on lines
+33
to
+36
| {isLoggedIn && !isLoading && cartCount! > 0 && ( | ||
| <span className={styles.num_cart}>{cartCount}</span> | ||
| )} | ||
| {isLoading && <Spinner />} |
There was a problem hiding this comment.
- 카운트 표기할 때
cartCount! > 0요 조건이 있는데,cartCount가 non-null로 단언이 되어 있는 것 같아요.cartCount는 API 응답인데 이렇게 단언해도 되나요?? - 로딩 중일 때 스피너가 뜨도록 되어 있는데, 스피너가 뜨면 화면 상호작용이 불가능합니다. 장바구니 아이템 개수 렌더링 같은 경우는 페이지 상호작용을 멈춰야 할 정도로 중요한 작업이 아니라고 봅니다. 그래서 스피너를 굳이 띄울 필요가 없다고 생각하는데 어떻게 생각하시나요?
There was a problem hiding this comment.
- API 응답이 완료되지 않으면
!isLoading에서 이미false를 리턴하니까cartCount가null값일 수가 없어요. 만약 API 요청에서 에러가 발생해 에러핸들링하는 경우를 말씀하시는거라면 이 컴포넌트가 아니라 인터셉트에서 핸들링하는게 낫지 않을까요? - 음... 그런것 같기도 하네요... 제거하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close: #385
📝작업 내용
🙏리뷰 요구사항(선택)